Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow react 0.14.0-beta1 as peer dependency #19

Closed
cesarandreu opened this issue Jul 27, 2015 · 2 comments
Closed

Allow react 0.14.0-beta1 as peer dependency #19

cesarandreu opened this issue Jul 27, 2015 · 2 comments

Comments

@cesarandreu
Copy link
Contributor

Would you consider allowing react 0.14.0-beta1 as a peer dependency?

I haven't tried react-helmet with react 0.14.0-beta1 yet, but from glancing at the code it looks like 0.14.0-beta1 should work.

For reference, a project that support react 0.14.0-beta1 is react-dnd, they declare the peer dependency is declared as:

{
  "peerDependencies": {
    "react": ">=0.13.0 <0.15.0 || 0.14.0-beta1"
  }
}
@cwelch5
Copy link
Contributor

cwelch5 commented Jul 28, 2015

Thanks for the inquiry. Yes, we definitely want to open react-helmet up to be utilized in new versions of React.

PR is here: #20

@cesarandreu
Copy link
Contributor Author

Awesome! :D

@cwelch5 cwelch5 closed this as completed Aug 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants