Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neon.Deployment dupicates functionality from Neon.Git #45

Open
jefflill opened this issue Jan 4, 2023 · 0 comments
Open

Neon.Deployment dupicates functionality from Neon.Git #45

jefflill opened this issue Jan 4, 2023 · 0 comments
Assignees
@jefflill
Labels
breaking This is a breaking change refactor Significant code refactoring

Comments

@jefflill
Copy link
Contributor

jefflill commented Jan 4, 2023

We've concentrating git related APIs and helpers into Neon.Git. Some of this code was copied from Neon.Deployment, so now this code is duplicated in these two libraries.

We need to refactor Neon.Deployment a bit to reference Neon.Git and then use those APIs or perhaps drop GitHub support from the deployment APIs completely, That may make more sense because the current GitHub related deployment API is pretty broken because is only supports managing one repo at a time.
@jefflill jefflill self-assigned this Jan 4, 2023
@jefflill jefflill added breaking This is a breaking change refactor Significant code refactoring labels Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jefflill jefflill

Labels
breaking This is a breaking change refactor Significant code refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jefflill