Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression error is reported as being very high #7

Closed
nfrechette opened this issue Nov 15, 2018 · 0 comments
Closed

Compression error is reported as being very high #7

nfrechette opened this issue Nov 15, 2018 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@nfrechette
Copy link
Owner

nfrechette commented Nov 15, 2018

Some UE4 animation sequences can have a sample/frame rate that isn't a whole number. e.g. 5 frames in 4 seconds. This does not usually happen but old sequences might have been impacted by an import bug sometime in the past.

ACL rounds the frame rate to a whole number and uses it to optimize the error but as a result, it does not measure the error like UE4 does. Even though the ACL reported error will still be very low, UE4 might report a high error. This happens because they disagree on where to measure the error in the animation sequence. As such, even though UE4 might report a high error, the sequence itself should be very accurate regardless and any error is unlikely to be visible to the naked eye.

A workaround is to re-import those impacted sequences to make sure their frame rate is a whole number (e.g. 30 FPS).

ACL will implement floating point sample rate support at some point in the future, this is tracked by this issue: nfrechette/acl#123

@nfrechette nfrechette added the bug Something isn't working label Nov 15, 2018
@nfrechette nfrechette added this to the Backlog milestone Nov 15, 2018
@nfrechette nfrechette modified the milestones: Backlog, v1.0 Nov 28, 2018
@nfrechette nfrechette self-assigned this Dec 28, 2018
@nfrechette nfrechette modified the milestones: v1.0, v0.3 Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant