Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One set of image & json will be missing #70

Closed
shingsoso opened this issue Feb 27, 2022 · 2 comments
Closed

One set of image & json will be missing #70

shingsoso opened this issue Feb 27, 2022 · 2 comments
Assignees

Comments

@shingsoso
Copy link

There is always one set of image and json missing when we have multiple layer configuration and shuffleLayerConfiguration.

For example , with the setting below :

const layerConfigurations = [
  {
    growEditionSizeTo: 2,
    layersOrder: [ ...]
   },
  {
    growEditionSizeTo: 5,
    layersOrder: [ ...]
   }
];

const shuffleLayerConfigurations = true;

The 2.png & 2.json will always be missing in the build.

@shingsoso
Copy link
Author

I have made a quick fix on the issue above , in the /src/main.js
The quick fix is to change the line in while loop to this :
editionCount <= layerConfigurations[layerConfigIndex].growEditionSizeTo + 1

const startCreating = async (storedDNA) => {
  if (storedDNA) {
    console.log(`using stored dna of ${storedDNA.size}`);
    dnaList = storedDNA;
  }
...
    while (
      editionCount <= layerConfigurations[layerConfigIndex].growEditionSizeTo + 1
    ) {
      let newDna = createDna(layers);
   ...
};

@nftchef
Copy link
Owner

nftchef commented Nov 11, 2022

No longer an issue

@nftchef nftchef closed this as completed Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants