-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial version of Metaplex integration #431
Comments
If we can avoid doing our own additional indexing (on write) for this we should. That was a hypothetical workaround that i hope we don’t need. There are minor API differences in nft/web3.storage and a few backend differences we hope to be rid of soon. At this point I’ll just let @yusefnapora decide which one is the best fit once he’s in there solving problems 😁 |
Just waiting to push to production |
@yusefnapora do you think we can close? maybe after tags are added? |
OK will close this once #948 is added, we make the changes to the Metaplex PR (and let Magic Eden know to include a tag), and then add a PR requiring the tag. |
Initial version is up, @yusefnapora feel free to make any new issues for work outstanding |
Adding acceptance criteria (@yusefnapora):
previous issue:
We want to write a PR to https://github.com/metaplex-foundation/metaplex to integrate with Web3.Storag. @mikeal can you chime in with why you were thinking Web3.Storage would be better? Then we can move this issue over to there.
We've been told this includes making a serverless cloud function that stores data for the Metaplex user and returns what needs to be put into the contract, as well as a PR to Metaplex to offer this as an option.
We'll do some more digging around to see if there's a specific place in their codebase to understand what's needed. @yusefnapora we have a call with them tomorrow morning and will ask and edit this section. Otherwise would be great if you could do some digging and populate this issue with what you find. Moving forward we can also probably pop into their Discord to ask questions: https://discord.gg/bnkV9cRX
Re: the cloud function, we'll just ask them to store using a single user token at this point, and can always expand to adopt new features. We don't think there should be any rate limiting issues if it's a serverless cloud function making the request (since it should be different IP addresses each time). I think Metaplex hosts their own cloud functions, so we can ask to figure out what the path would be to handing it off to them.
We also discussed potentially using the cloud function to index the CID + Solana wallet address for each user. This is publicly available data on the Solana chain, but depending on how easy it is to query it, we might want to do this indexing ourselves (since we won't have any granularity on who stored what data otherwise, given there will be a single Metaplex user at first). I think it's probably fine not to do, but let's discuss (cc @mikeal).
The text was updated successfully, but these errors were encountered: