Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET https://api.nftstorage.link/perma-cache/:url #101

Closed
alanshaw opened this issue May 20, 2022 · 1 comment · Fixed by #140
Closed

GET https://api.nftstorage.link/perma-cache/:url #101

alanshaw opened this issue May 20, 2022 · 1 comment · Fixed by #140
Labels
blocked effort/quickwin kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up

Comments

@alanshaw
Copy link
Contributor

Currently the gateway is configured with the same R2 bucket that the perma cache API uses and has to know how to retrieve data from it when given a URL that was previously cached by perma cache. All this knowledge and configuration should live only in the perma-cache API and we should instead expose an API route allowing the gateway to retrieve data using just a URL.

i.e. currently:

# caching data:
user -> perma-cache -> R2
# retrieving data
user <- gateway <- R2

change to:

# caching data:
user -> perma-cache -> R2
# retrieving data
user <- gateway <- perma-cache <- R2

New API route:

GET https://api.nftstorage.link/perma-cache/:url
@alanshaw alanshaw added kind/enhancement A net-new feature or improvement to an existing feature need/triage Needs initial labeling and prioritization labels May 20, 2022
@dchoi27
Copy link
Contributor

dchoi27 commented May 23, 2022

Currently blocked on service bindings being released

@dchoi27 dchoi27 added effort/quickwin P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked effort/quickwin kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants