feat: support base cid encodings #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
f89f851
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0673bfe5.nftstorage-link.pages.dev |
| Branch Preview URL: | https://feat-support-base-cid-encodi.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
feat/support-base-cid-encodings
branch
from
6fdd386
to
811fc79
Compare
vasco-santos
commented
Jun 20, 2022
| * | ||
| * @param {string} cid | ||
| */ | ||
| async function normalizeCidV1(cid) { |
There was a problem hiding this comment.
Created new one as per CID spec when cidv0 we don't have a multibasePrefix. normalizeCidV1 always comes from this path as function is not exported and is used on subdomain
vasco-santos
force-pushed
the
feat/support-base-cid-encodings
branch
2 times, most recently
from
29838d4
to
70c3f8e
Compare
vasco-santos
force-pushed
the
feat/support-base-cid-encodings
branch
from
70c3f8e
to
f89f851
Compare
Codecov Report
@@ Coverage Diff @@
## main #148 +/- ##
=======================================
Coverage ? 98.98%
=======================================
Files ? 4
Lines ? 491
Branches ? 0
=======================================
Hits ? 486
Misses ? 5
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for gateway to try to resolve CIDs encoded into more bases than b32 and b58. It includes all the basic bases exported by multiformats module.
ipfs-core-utilswas added to have a quick way of getting what base decoder we want to try.Closes #111