fix: retry gateway denly list kv get #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanshaw
approved these changes
Apr 22, 2022
packages/edge-gateway/src/gateway.js
Outdated
| // TODO: in theory we should check each subcomponent of the pathname also. | ||
| // https://github.com/nftstorage/nft.storage/issues/1737 | ||
| const value = await env.DENYLIST.get(anchor) | ||
| // TODO: Remove once CF team as a solution for "Network connection lost" Errors |
There was a problem hiding this comment.
hmm, would be good to cite an issue here with more context.
vasco-santos
commented
Apr 22, 2022
Deploying with
|
| Latest commit: |
7f2c69e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7ee7d9a.nftstorage-link.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to "solve" Network Connection Lost errors https://sentry.io/organizations/protocol-labs-it/issues/3111298942/?environment=production&project=6097112&query=is%3Aunresolved that became quite frequent during the last few days.
This is a temporary solution until we figure out with CF Workers team what is the underlying issue per feedback in https://discord.com/channels/595317990191398933/779390076219686943/967047749881192468