fix: integrate edge gateway in api until workers bindings available #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
062dfcb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fcdaec08.nftstorage-link.pages.dev |
vasco-santos
force-pushed
the
fix/integrate-edge-gateway-in-api-until-workers-bindings-available
branch
7 times, most recently
from
9143d12
to
3e06e41
Compare
vasco-santos
force-pushed
the
fix/integrate-edge-gateway-in-api-until-workers-bindings-available
branch
from
3e06e41
to
61fd1d1
Compare
vasco-santos
force-pushed
the
fix/integrate-edge-gateway-in-api-until-workers-bindings-available
branch
3 times, most recently
from
75d9350
to
0887ffb
Compare
vasco-santos
force-pushed
the
fix/integrate-edge-gateway-in-api-until-workers-bindings-available
branch
from
0887ffb
to
0137a42
Compare
alanshaw
approved these changes
May 17, 2022
vasco-santos
force-pushed
the
fix/integrate-edge-gateway-in-api-until-workers-bindings-available
branch
from
0137a42
to
062dfcb
Compare
vasco-santos
deleted the
fix/integrate-edge-gateway-in-api-until-workers-bindings-available
branch
This was referenced May 17, 2022
This was referenced Aug 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two workers now, one for the gateway and one for the API, as they should just be independent services.
As part of
/perma-cache/put/, a request must be performed to the gateway in order to get the response to be stored in R2. However, two workers cannot HTTP with each other if they are within same CF zone (nftstorage.link).There is a brand new solution for this https://blog.cloudflare.com/service-bindings-ga/ which as of 10th May is now open. However, there is an incompatibility between Service Bindings and R2. When we do a fetch from a Service Binding and put its response in R2 it errors (created a reproduction case and shared with CF a few weeks ago https://github.com/vasco-santos/workers-bindings-r2 but waiting on getting it fixed).
As a way to be able to test this in staging, this PR has a small refactor on gateway code to export relevant function that API can just import and use (of course with its own ENV Vars properly setup...).
This can also be seen as a first step to extract common code of the gateway to a lib. But I avoided much complexity now and It essentially decouples all Durable Objects related code and adds callbacks for it. We will still need to discuss better how to decouple remaining pieces for getting an independent lib extracted.