fix: gateway histogram response time only updated on 200 #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: Should go after #79 to avoid messing up with DO migrations on release |
alanshaw
reviewed
May 10, 2022
| @@ -19,11 +19,12 @@ import { | |||
| */ | |||
|
|
|||
| const GATEWAY_METRICS_ID = 'gateway_metrics' | |||
| const SUCCESS_STATUS = 200 | |||
There was a problem hiding this comment.
You have HTTP_STATUS_SUCCESS in constants.js
| @@ -85,6 +86,16 @@ export class GatewayMetrics0 { | |||
| this.gatewayMetrics.totalWinnerRequests += 1 | |||
| } | |||
|
|
|||
| // Only update response time histogram if response is successful | |||
| if (stats.status === SUCCESS_STATUS) { | |||
| this._updateResponseTimeHistogram(stats) | |||
There was a problem hiding this comment.
It's now not obvious that this statistic is for successful responses - perhaps we should rename to reflect the change here?
Deploying with
|
| Latest commit: |
b488375
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9ea612f6.nftstorage-link.pages.dev |
alanshaw
approved these changes
May 11, 2022
vasco-santos
force-pushed
the
fix/gateway-histogram-response-time-only-updated-on-200
branch
from
63c7f2e
to
d0a9d02
Compare
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
vasco-santos
deleted the
fix/gateway-histogram-response-time-only-updated-on-200
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that Pinata was having really fast responses but number did not make sense. Turns out 🤦🏼♂️ we were counting other status codes for the response, which since we introduced pinata.nftstorage.link with out own rate limit errors were resulting in lot's of really fast 429 responses.