Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add RTLService service #1120

Merged
merged 8 commits into from Jan 3, 2021
Merged

feat(theme): add RTLService service #1120

merged 8 commits into from Jan 3, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jan 1, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Jan 1, 2021

Codecov Report

Merging #1120 (5317456) into master (9ea783e) will decrease coverage by 0.08%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1120      +/-   ##
==========================================
- Coverage   96.19%   96.11%   -0.09%     
==========================================
  Files         237      238       +1     
  Lines        7496     7547      +51     
  Branches     1359     1363       +4     
==========================================
+ Hits         7211     7254      +43     
- Misses        149      153       +4     
- Partials      136      140       +4     
Impacted Files Coverage Δ
packages/theme/src/services/rtl/rtl.service.ts 84.00% <84.00%> (ø)
packages/abc/avatar-list/avatar-list.component.ts 94.87% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ea783e...5317456. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Jan 1, 2021

Preview is ready!

@cipchk cipchk merged commit 1f4f67b into master Jan 3, 2021
@cipchk cipchk deleted the issues-rtl-service branch January 3, 2021 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants