Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:onboarding): fix closed mask when click target element #1202

Merged
merged 2 commits into from Mar 7, 2021

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Mar 6, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 6, 2021

Codecov Report

Merging #1202 (34239ae) into master (7bf3563) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1202   +/-   ##
=======================================
  Coverage   96.32%   96.32%           
=======================================
  Files         268      268           
  Lines        8053     8056    +3     
  Branches     1475     1475           
=======================================
+ Hits         7757     7760    +3     
  Misses        135      135           
  Partials      161      161           
Impacted Files Coverage Δ
packages/abc/onboarding/onboarding.component.ts 95.94% <100.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf3563...34239ae. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Mar 6, 2021

Preview is ready!

@cipchk cipchk merged commit b741b4c into master Mar 7, 2021
@cipchk cipchk deleted the issues-onboarding branch March 7, 2021 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants