Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme:SettingsService): support generic #1207

Merged
merged 1 commit into from Mar 10, 2021
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Mar 10, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #1207 (23bff31) into master (7ca7458) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1207   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files         268      268           
  Lines        8072     8072           
  Branches     1478     1478           
=======================================
  Hits         7776     7776           
  Misses        135      135           
  Partials      161      161           
Impacted Files Coverage Δ
...es/theme/src/services/settings/settings.service.ts 92.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca7458...a8c0ea4. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Mar 10, 2021

Preview is ready!

@cipchk cipchk merged commit c2532f8 into master Mar 10, 2021
@cipchk cipchk deleted the issues-settings-generic branch March 10, 2021 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants