Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): fix buttons misalignment in inline layout #1442

Merged
merged 1 commit into from Feb 14, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Feb 14, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #1442 (4809ee3) into master (43595f2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4809ee3 differs from pull request most recent head 6248e62. Consider uploading reports for the commit 6248e62 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1442   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files         265      265           
  Lines        8103     8104    +1     
  Branches     1606     1606           
=======================================
+ Hits         7831     7832    +1     
  Misses        185      185           
  Partials       87       87           
Impacted Files Coverage Δ
packages/form/src/sf-item.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43595f2...6248e62. Read the comment docs.

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Feb 14, 2022

Preview is ready!

@cipchk cipchk merged commit 1e836f8 into master Feb 14, 2022
@cipchk cipchk deleted the issues-form-button-inline branch February 14, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants