Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add provideAlain #1697

Merged
merged 5 commits into from Nov 11, 2023
Merged

feat(theme): add provideAlain #1697

merged 5 commits into from Nov 11, 2023

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Nov 11, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented Nov 11, 2023

Preview is ready!

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Merging #1697 (c630059) into master (683ab23) will decrease coverage by 0.07%.
The diff coverage is 25.00%.

❗ Current head c630059 differs from pull request most recent head 51d91d8. Consider uploading reports for the commit 51d91d8 to get more accurate results

@@            Coverage Diff             @@
##           master    #1697      +/-   ##
==========================================
- Coverage   95.52%   95.46%   -0.07%     
==========================================
  Files         299      300       +1     
  Lines        8828     8836       +8     
  Branches     1660     1660              
==========================================
+ Hits         8433     8435       +2     
- Misses        325      331       +6     
  Partials       70       70              
Files Coverage Δ
...es/theme/src/services/settings/settings.service.ts 96.42% <100.00%> (+0.06%) ⬆️
packages/theme/src/provide.ts 0.00% <0.00%> (ø)
packages/theme/src/theme.module.ts 60.00% <20.00%> (-40.00%) ⬇️

@cipchk cipchk merged commit 4311426 into master Nov 11, 2023
9 checks passed
@cipchk cipchk deleted the feat-provideAlain branch November 11, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants