Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form:select): fix invlaid tag count #571

Merged
merged 1 commit into from May 15, 2019
Merged

fix(form:select): fix invlaid tag count #571

merged 1 commit into from May 15, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented May 15, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #571 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #571   +/-   ##
======================================
  Coverage    98.7%   98.7%           
======================================
  Files         260     260           
  Lines        7424    7424           
  Branches     1105    1105           
======================================
  Hits         7328    7328           
  Misses         33      33           
  Partials       63      63
Impacted Files Coverage Δ
packages/form/src/widgets/select/select.widget.ts 83.78% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b625b4...752634b. Read the comment docs.

@cipchk cipchk merged commit 56abb18 into master May 15, 2019
@cipchk cipchk deleted the issues-1089 branch May 20, 2019 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants