Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix Invalid "extends" configuration value #824

Merged
merged 1 commit into from Apr 20, 2020
Merged

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 20, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Apr 20, 2020

Preview is ready!

@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #824 into master will decrease coverage by 0.07%.
The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
- Coverage   97.64%   97.57%   -0.08%     
==========================================
  Files         239      239              
  Lines        6889     6895       +6     
  Branches     1297     1300       +3     
==========================================
+ Hits         6727     6728       +1     
- Misses        104      108       +4     
- Partials       58       59       +1     
Impacted Files Coverage Δ
packages/chart/tag-cloud/tag-cloud.component.ts 31.50% <33.33%> (+0.16%) ⬆️
packages/util/src/logger/logger.ts 81.81% <50.00%> (-4.55%) ⬇️
packages/chart/timeline/timeline.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d0146...08ab9b0. Read the comment docs.

@cipchk cipchk merged commit 68b56c4 into master Apr 20, 2020
@cipchk cipchk deleted the issues-1577 branch April 20, 2020 09:02
goten002 pushed a commit to goten002/delon that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant