Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form:widget:date): fix format default value #833

Merged
merged 2 commits into from Apr 21, 2020
Merged

fix(form:widget:date): fix format default value #833

merged 2 commits into from Apr 21, 2020

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 21, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Copy link
Member Author

cipchk commented Apr 21, 2020

Preview is ready!

@codecov
Copy link

codecov bot commented Apr 21, 2020

Codecov Report

Merging #833 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #833      +/-   ##
==========================================
+ Coverage   97.58%   97.59%   +0.01%     
==========================================
  Files         241      241              
  Lines        6909     6910       +1     
  Branches     1305     1305              
==========================================
+ Hits         6742     6744       +2     
  Misses        108      108              
+ Partials       59       58       -1     
Impacted Files Coverage Δ
packages/form/src/widgets/date/date.widget.ts 94.91% <100.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04e6983...527a4c0. Read the comment docs.

@cipchk cipchk merged commit 92821b0 into master Apr 21, 2020
@cipchk cipchk deleted the issues-1560 branch April 21, 2020 19:23
goten002 pushed a commit to goten002/delon that referenced this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant