-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(popover): avoid shadowing of the native title property
BREAKING CHANGE: the title property of the popover directive was renamed to popoverTitle. Before: `<div ngbPopover="..." title="...">` after: `<div ngbPopover="..." popoverTitle="...">` Fixes #736 Closes #757
- Loading branch information
1 parent
79e393d
commit 2577efd
Showing
6 changed files
with
14 additions
and
14 deletions.
There are no files selected for viewing
8 changes: 4 additions & 4 deletions
8
demo/src/app/components/popover/demos/basic/popover-basic.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
<button type="button" class="btn btn-secondary" placement="top" | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." title="Popover on top"> | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." popoverTitle="Popover on top"> | ||
Popover on top | ||
</button> | ||
|
||
<button type="button" class="btn btn-secondary" placement="right" | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." title="Popover on right"> | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." popoverTitle="Popover on right"> | ||
Popover on right | ||
</button> | ||
|
||
<button type="button" class="btn btn-secondary" placement="bottom" | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." title="Popover on bottom"> | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." popoverTitle="Popover on bottom"> | ||
Popover on bottom | ||
</button> | ||
|
||
<button type="button" class="btn btn-secondary" placement="left" | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." title="Popover on left"> | ||
ngbPopover="Vivamus sagittis lacus vel augue laoreet rutrum faucibus." popoverTitle="Popover on left"> | ||
Popover on left | ||
</button> |
2 changes: 1 addition & 1 deletion
2
demo/src/app/components/popover/demos/config/popover-config.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
<button type="button" class="btn btn-secondary" | ||
ngbPopover="This popover gets its inputs from the customized configuration" title="Customized popover"> | ||
ngbPopover="This popover gets its inputs from the customized configuration" popoverTitle="Customized popover"> | ||
Customized popover | ||
</button> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters