fix(rating): correct aria attribute setting

Closes #1479
ng-bootstrap · Apr 12, 2017 · 4575573 · 4575573
1 parent 5954553
commit 4575573
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/rating/rating.spec.ts b/src/rating/rating.spec.ts
@@ -323,6 +323,14 @@ describe('ngb-rating', () => {
       expect(rating.attributes['aria-valuemax']).toBe('10');
     });
 
+    it('contains aria-valuemin', () => {
+      const fixture = createTestComponent('<ngb-rating [max]="max"></ngb-rating>');
+
+      const rating = fixture.debugElement.query(By.directive(NgbRating));
+
+      expect(rating.attributes['aria-valuemin']).toBe('0');
+    });
+
     it('contains a hidden span for each star for screenreaders', () => {
       const fixture = createTestComponent('<ngb-rating max="5"></ngb-rating>');
 

diff --git a/src/rating/rating.ts b/src/rating/rating.ts
@@ -51,7 +51,7 @@ const NGB_RATING_VALUE_ACCESSOR = {
     'class': 'd-inline-flex',
     'tabindex': '0',
     'role': 'slider',
-    'attr.aria-valuemin': '0',
+    'aria-valuemin': '0',
     '[attr.aria-valuemax]': 'max',
     '[attr.aria-valuenow]': 'nextRate',
     '[attr.aria-valuetext]': 'ariaValueText()',