fix(tabset): remove unneeded tabpanel role on container

Closes #1409
ng-bootstrap · Mar 27, 2017 · 5005384 · 5005384
1 parent 493d0b3
commit 5005384
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 7 deletions.
diff --git a/src/tabset/tabset.spec.ts b/src/tabset/tabset.spec.ts
@@ -10,10 +10,6 @@ import {NgbTabset} from './tabset';
 const createTestComponent = (html: string) =>
     createGenericTestComponent(html, TestComponent) as ComponentFixture<TestComponent>;
 
-function getTabset(nativeEl: HTMLElement) {
-  return nativeEl.querySelector('ngb-tabset');
-}
-
 function getTabTitles(nativeEl: HTMLElement) {
   return nativeEl.querySelectorAll('.nav-link');
 }
@@ -93,11 +89,9 @@ describe('ngb-tabset', () => {
     `);
 
     const compiled: HTMLElement = fixture.nativeElement;
-    const tabset = getTabset(compiled);
     const tabTitles = getTabTitles(compiled);
     const tabContent = getTabContent(compiled);
 
-    expect(tabset.getAttribute('role')).toBe('tabpanel');
     expect(tabTitles[0].getAttribute('role')).toBe('tab');
     expect(tabTitles[0].getAttribute('aria-expanded')).toBe('true');
     expect(tabTitles[1].getAttribute('aria-expanded')).toBe('false');

diff --git a/src/tabset/tabset.ts b/src/tabset/tabset.ts
@@ -78,7 +78,6 @@ export interface NgbTabChangeEvent {
 @Component({
   selector: 'ngb-tabset',
   exportAs: 'ngbTabset',
-  host: {'role': 'tabpanel'},
   template: `
     <ul [class]="'nav nav-' + type + ' justify-content-' + justify" role="tablist">
       <li class="nav-item" *ngFor="let tab of tabs">