Skip to content

Commit

Permalink
feat(collapse): upgrade collapse to v4-alpha.6
Browse files Browse the repository at this point in the history
refs #1178
Closes #1183
  • Loading branch information
jnizet authored and pkozlowski-opensource committed Jan 9, 2017
1 parent 7ab022b commit 6cda8b3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
14 changes: 7 additions & 7 deletions src/collapse/collapse.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ describe('ngb-collapse', () => {

const collapseEl = getCollapsibleContent(fixture.nativeElement);

expect(collapseEl).toHaveCssClass('in');
expect(collapseEl).toHaveCssClass('show');
expect(collapseEl.getAttribute('aria-expanded')).toBe('true');
});

Expand All @@ -38,7 +38,7 @@ describe('ngb-collapse', () => {

const collapseEl = getCollapsibleContent(fixture.nativeElement);

expect(collapseEl).not.toHaveCssClass('in');
expect(collapseEl).not.toHaveCssClass('show');
expect(collapseEl.getAttribute('aria-expanded')).toBe('false');
});

Expand All @@ -48,15 +48,15 @@ describe('ngb-collapse', () => {

const tc = fixture.componentInstance;
const collapseEl = getCollapsibleContent(fixture.nativeElement);
expect(collapseEl).toHaveCssClass('in');
expect(collapseEl).toHaveCssClass('show');

tc.collapsed = true;
fixture.detectChanges();
expect(collapseEl).not.toHaveCssClass('in');
expect(collapseEl).not.toHaveCssClass('show');

tc.collapsed = false;
fixture.detectChanges();
expect(collapseEl).toHaveCssClass('in');
expect(collapseEl).toHaveCssClass('show');
});

it('should allow toggling collapse from outside', () => {
Expand All @@ -72,11 +72,11 @@ describe('ngb-collapse', () => {

buttonEl.click();
fixture.detectChanges();
expect(collapseEl).not.toHaveCssClass('in');
expect(collapseEl).not.toHaveCssClass('show');

buttonEl.click();
fixture.detectChanges();
expect(collapseEl).toHaveCssClass('in');
expect(collapseEl).toHaveCssClass('show');
});
});

Expand Down
2 changes: 1 addition & 1 deletion src/collapse/collapse.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {Directive, Input} from '@angular/core';
@Directive({
selector: '[ngbCollapse]',
exportAs: 'ngbCollapse',
host: {'[class.collapse]': 'true', '[class.in]': '!collapsed', '[attr.aria-expanded]': '!collapsed'}
host: {'[class.collapse]': 'true', '[class.show]': '!collapsed', '[attr.aria-expanded]': '!collapsed'}
})
export class NgbCollapse {
/**
Expand Down

0 comments on commit 6cda8b3

Please sign in to comment.