feat(modal): Add xl size for modal (#3239)

First intent of this PR was made by @bastienmoulia via #2943
ng-bootstrap · Jun 24, 2019 · 998f358 · 998f358
1 parent e682ee3
commit 998f358
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 3 deletions.
diff --git a/demo/src/app/components/modal/demos/options/modal-options.html b/demo/src/app/components/modal/demos/options/modal-options.html
@@ -49,5 +49,6 @@ <h4 class="modal-title">Modal title</h4>
 <button class="btn btn-outline-primary mb-2 mr-2" (click)="openBackDropCustomClass(content)">Modal with backdrop custom class</button>
 <button class="btn btn-outline-primary mb-2 mr-2" (click)="openSm(content)">Small modal</button>
 <button class="btn btn-outline-primary mb-2 mr-2" (click)="openLg(content)">Large modal</button>
+<button class="btn btn-outline-primary mb-2 mr-2" (click)="openXl(content)">Extra large modal</button>
 <button class="btn btn-outline-primary mb-2 mr-2" (click)="openVerticallyCentered(content)">Modal vertically centered</button>
 <button class="btn btn-outline-primary mb-2 mr-2" (click)="openScrollableContent(longContent)">Modal scrollable content</button>
diff --git a/demo/src/app/components/modal/demos/options/modal-options.ts b/demo/src/app/components/modal/demos/options/modal-options.ts
@@ -39,6 +39,8 @@ export class NgbdModalOptions {
     this.modalService.open(content, { size: 'lg' });
   }
 
+  openXl(content) { this.modalService.open(content, {size: 'xl'}); }
+
   openVerticallyCentered(content) {
     this.modalService.open(content, { centered: true });
   }

diff --git a/misc/api-doc-test-cases/interface-with-properties.ts b/misc/api-doc-test-cases/interface-with-properties.ts
@@ -16,5 +16,5 @@ export interface NgbModalOptions {
   /**
    * Size of a new modal window.
    */
-  size?: 'sm' | 'lg';
+  size?: 'sm' | 'lg' | 'xl';
 }
diff --git a/misc/api-doc.spec.ts b/misc/api-doc.spec.ts
@@ -182,7 +182,7 @@ describe('APIDocVisitor', () => {
 
     expect(interfaceDocs.properties[2].name).toBe('size');
     expect(interfaceDocs.properties[2].description).toBe('<p>Size of a new modal window.</p>');
-    expect(interfaceDocs.properties[2].type).toBe('"sm" | "lg"');
+    expect(interfaceDocs.properties[2].type).toBe('"sm" | "lg" | "xl"');
     expect(interfaceDocs.properties[2].defaultValue).toBeUndefined();
   });
 

diff --git a/src/modal/modal-config.ts b/src/modal/modal-config.ts
@@ -70,7 +70,7 @@ export interface NgbModalOptions {
   /**
    * Size of a new modal window.
    */
-  size?: 'sm' | 'lg';
+  size?: 'sm' | 'lg' | 'xl';
 
   /**
    * A custom class to append to the modal window.