fix(collapse): remove aria-expanded from target

Closes #1492
ng-bootstrap · Apr 13, 2017 · a24b283 · a24b283
1 parent 513cc1c
commit a24b283
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/collapse/collapse.spec.ts b/src/collapse/collapse.spec.ts
@@ -20,17 +20,16 @@ describe('ngb-collapse', () => {
     TestBed.overrideComponent(TestComponent, {set: {template: html}});
   });
 
-  it('should have content open and aria-expanded true', () => {
+  it('should have content open', () => {
     const fixture = TestBed.createComponent(TestComponent);
     fixture.detectChanges();
 
     const collapseEl = getCollapsibleContent(fixture.nativeElement);
 
     expect(collapseEl).toHaveCssClass('show');
-    expect(collapseEl.getAttribute('aria-expanded')).toBe('true');
   });
 
-  it('should have content closed and aria-expanded false', () => {
+  it('should have content closed', () => {
     const fixture = TestBed.createComponent(TestComponent);
     const tc = fixture.componentInstance;
     tc.collapsed = true;
@@ -39,7 +38,6 @@ describe('ngb-collapse', () => {
     const collapseEl = getCollapsibleContent(fixture.nativeElement);
 
     expect(collapseEl).not.toHaveCssClass('show');
-    expect(collapseEl.getAttribute('aria-expanded')).toBe('false');
   });
 
   it('should toggle collapsed content based on bound model change', () => {

diff --git a/src/collapse/collapse.ts b/src/collapse/collapse.ts
@@ -6,7 +6,7 @@ import {Directive, Input} from '@angular/core';
 @Directive({
   selector: '[ngbCollapse]',
   exportAs: 'ngbCollapse',
-  host: {'[class.collapse]': 'true', '[class.show]': '!collapsed', '[attr.aria-expanded]': '!collapsed'}
+  host: {'[class.collapse]': 'true', '[class.show]': '!collapsed'}
 })
 export class NgbCollapse {
   /**