feat(rating): set aria-disabled="true" when readonly

Closes #1489
ng-bootstrap · Apr 13, 2017 · c89f2c4 · c89f2c4
1 parent 88a7f00
commit c89f2c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/rating/rating.spec.ts b/src/rating/rating.spec.ts
@@ -376,6 +376,18 @@ describe('ngb-rating', () => {
 
       expect(rating.attributes['aria-valuetext']).toBe('7 out of 10');
     });
+
+    it('updates aria-disabled when readonly', () => {
+      const fixture = createTestComponent('<ngb-rating></ngb-rating>');
+      let ratingEl = fixture.debugElement.query(By.directive(NgbRating));
+      fixture.detectChanges();
+      expect(ratingEl.attributes['aria-disabled']).toBeNull();
+
+      let ratingComp = <NgbRating>ratingEl.componentInstance;
+      ratingComp.readonly = true;
+      fixture.detectChanges();
+      expect(ratingEl.attributes['aria-disabled']).toBe('true');
+    });
   });
 
   describe('keyboard support', () => {

diff --git a/src/rating/rating.ts b/src/rating/rating.ts
@@ -55,6 +55,7 @@ const NGB_RATING_VALUE_ACCESSOR = {
     '[attr.aria-valuemax]': 'max',
     '[attr.aria-valuenow]': 'nextRate',
     '[attr.aria-valuetext]': 'ariaValueText()',
+    '[attr.aria-disabled]': 'readonly ? true : null',
     '(mouseleave)': 'reset()',
     '(keydown)': 'handleKeyDown($event)'
   },