Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): use td in arrows navigation #1086

Merged
merged 1 commit into from
Nov 27, 2016

Conversation

aitboudad
Copy link
Contributor

No description provided.

@wesleycho
Copy link
Member

LGTM, but there might be a reason why a div was used over a td.

Did this cause a particular issue for you?

@aitboudad
Copy link
Contributor Author

to make arrows consistent and to simplify applying custom styles

@maxokorokov
Copy link
Member

@wesleycho no, there simply was a markup bug with next button

<table>
  <tr>
    <td>Prev</td>
    <td>...</td>
    <div>Next</div>
  </tr>
</table>

@aitboudad thanks for noticing

@maxokorokov maxokorokov merged commit 6b8827a into ng-bootstrap:master Nov 27, 2016
@aitboudad aitboudad deleted the patch-1 branch November 27, 2016 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants