feat(rating): enable form integration #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
reviewed
Nov 29, 2016
| @@ -0,0 +1,16 @@ | |||
| <p>You can use both ngModel and reactive forms. You don't have to use 'rate' binding in this case</p> | |||
There was a problem hiding this comment.
Probably would read better as
<p>ngModel and reactive forms can be used without using the 'rate' binding</p>
maxokorokov
force-pushed
the
rating_forms
branch
from
4edebd3
to
01e7645
Compare
maxokorokov
changed the title
maxokorokov
changed the title
|
Found an issue with readonly rating, will have to add some more tests... |
maxokorokov
force-pushed
the
rating_forms
branch
from
01e7645
to
a0a1449
Compare
maxokorokov
changed the title
|
It's OK now, but will add proper |
maxokorokov
force-pushed
the
rating_forms
branch
from
a0a1449
to
d0cb282
Compare
|
Any plan to merge this for the next release? |
|
LGTM generally speaking. Could you just update the commit message to have reference to the issue this commit is fixing? Also this one has a breaking change, no? (sync -> async delivery of events?) |
BREAKING CHANGES: event emitter behind the 'rateChange' output emits asynchronously now Fixes ng-bootstrap#1087
maxokorokov
force-pushed
the
rating_forms
branch
from
d0cb282
to
34b3c2e
Compare
|
Resolved conflicts and updated commit message with breaking changes. Can merge when green then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables form integration for rating:
rateevent emitter becomes asynchronous (same story as pagination)[(rate)]and[(ngModel)]Fixes #1087