fix(pagination): prevent focus of disabled selectors #1114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeg
force-pushed
the
pagination-focus
branch
from
8e0c465
to
dee77c1
Compare
deeg
added a commit
to deeg/ng-bootstrap
that referenced
this pull request
Dec 5, 2016
deeg
commented
Dec 5, 2016
| @@ -27,10 +27,16 @@ function expectPages(nativeEl: HTMLElement, pagesDef: string[]): void { | |||
| expect(pages[i]).not.toHaveCssClass('active'); | |||
| expect(pages[i]).toHaveCssClass('disabled'); | |||
| expect(normalizeText(pages[i].textContent)).toEqual(pageDef.substr(1)); | |||
| if (normalizeText(pages[i].textContent) !== '...') { | |||
There was a problem hiding this comment.
I did this to put the check in for all checkPages() calls. If you want me to break this out into a separate test I can.
maxokorokov
reviewed
Dec 9, 2016
| } else { | ||
| expect(pages[i]).not.toHaveCssClass('active'); | ||
| expect(pages[i]).not.toHaveCssClass('disabled'); | ||
| expect(normalizeText(pages[i].textContent)).toEqual(pageDef); | ||
| if (normalizeText(pages[i].textContent) !== '...') { | ||
| expect(pages[i].querySelector('a').getAttribute('tabindex')).not.toEqual('-1'); |
There was a problem hiding this comment.
maybe expect(pages[i].querySelector('a').hasAttribute('tabindex')).toBeFalsy()?
I think we're expecting that attribute should not be there at all
deeg
force-pushed
the
pagination-focus
branch
from
dee77c1
to
dea7032
Compare
|
Not sure why travis failed. Maybe it needs to be restarted? I think a saucelabs issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1108