feat(tabset): tabs horizontal alignment #1210
Conversation
| @@ -110,11 +110,16 @@ export class NgbTabset implements AfterContentChecked { | |||
| @Input() type: 'tabs' | 'pills'; | |||
|
|
|||
| /** | |||
| * The horizontal alignment of the nav with flexbox utilities. Can be one of 'start', 'center' or 'end' | |||
| */ | |||
| @Input() alignment: 'start' | 'center' | 'end'; | |||
There was a problem hiding this comment.
How about calling it justify?
There was a problem hiding this comment.
I had to pick between justify, align and alignement , @pkozlowski-opensource should we change the name to justify?
There was a problem hiding this comment.
My preference would go to justify so yes, let's change it.
|
Thnx for the PR. Could you please fix the linting issue? It fails the build currently: https://travis-ci.org/ng-bootstrap/ng-bootstrap/builds/191182918 |
There was a problem hiding this comment.
Thanks for this update. LGTM, except for component member alphabetic ordering as described in code conventions
| @@ -8,4 +8,5 @@ import {Injectable} from '@angular/core'; | |||
| @Injectable() | |||
| export class NgbTabsetConfig { | |||
| type: 'tabs' | 'pills' = 'tabs'; | |||
| justify: 'start' | 'center' | 'end' = 'start'; | |||
There was a problem hiding this comment.
Please order fields alphabetically
| @@ -110,11 +110,19 @@ export class NgbTabset implements AfterContentChecked { | |||
| @Input() type: 'tabs' | 'pills'; | |||
|
|
|||
| /** | |||
| * The horizontal alignment of the nav with flexbox utilities. Can be one of 'start', 'center' or 'end' | |||
| */ | |||
| @Input() justify: 'start' | 'center' | 'end'; | |||
There was a problem hiding this comment.
Please order inputs alphabetically
|
Merged as 00114f3, thnx |
Tabs Horizontal alignment
Add the horizontal alignment support to the tabs
http://v4-alpha.getbootstrap.com/components/navs/#horizontal-alignment