Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): add full month name versions to i18n #1217

Merged
merged 1 commit into from
Jan 17, 2017
Merged

feat(datepicker): add full month name versions to i18n #1217

merged 1 commit into from
Jan 17, 2017

Conversation

maxokorokov
Copy link
Member

Adding full month names to the datepicker:

  • full names are displayed above the grid with days
  • short names are displayed in selectboxes
  • renamed i18n methods for consistency

Short:
screen shot 2017-01-13 at 10 31 19

Full:
screen shot 2017-01-13 at 10 24 44

BREAKING CHANGES: NgbDatepickerI18n methods renamed

getWeekdayName to getWeekdayShortName
getMonthName to getMonthShortName

@maxokorokov
feat(datepicker): add full month name versions to i18n
8cfd93f 
BREAKING CHANGES: `NgbDatepickerI18n` methods renamed

`getWeekdayName` to `getWeekdayShortName`
`getMonthName` to `getMonthShortName`
deeg
deeg approved these changes Jan 14, 2017
View reviewed changes
Copy link
Contributor

@deeg deeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxokorokov maxokorokov merged commit 106fa82 into ng-bootstrap:master Jan 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Foxandxss Foxandxss Foxandxss approved these changes

@deeg deeg deeg approved these changes

Assignees
No one assigned
Labels
component: datepicker needs: review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxokorokov @Foxandxss @deeg