Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary ellipsis between sibling page numbers for rotating pagination #1232

Closed
dmytroyarmak opened this issue Jan 19, 2017 · 2 comments
Closed

Comments

@dmytroyarmak
Copy link
Contributor

Bug description:

In some cases, when using rotation pagination component renders unnecessary ellipsis between sibling page numbers.
For example for:

  • page numbers: 7
  • current page: 5
  • max pages: 3

The result will be (incorrect):

['« Previous', '1', '-...', '4', '+5', '6', '-...',  '7', '» Next']

instead of (correct)

['« Previous', '1', '-...', '4', '+5', '6', '7', '» Next']

The same problem happens on the 3rd page.

Link to minimally-working plunker that reproduces the issue:

http://plnkr.co/edit/Jr28Ft?p=preview

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 2.0.0

ng-bootstrap: 1.0.0-alpha.18

Bootstrap: 4.0.0-alpha.6

@pkozlowski-opensource
Copy link
Member

Sounds like #1166. I had a brief look at your PR at it seems fine. Will do a proper review & merge tomorrow.

Thnx for stepping in and contributing - much appreciated!

@pkozlowski-opensource
Copy link
Member

Merged, thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants