fix(datepicker): navigation arrows not responding on Firefox when navigation == "arrows" #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
datePickerBug
branch
from
5ee209f
to
1acf4b2
Compare
…igation=="arrows" When navigation == "arrows" on the datepicker component, navigation arrows are under the div.ngb-dp-month element, which prevents the click event from reaching navigation arrows on Firefox.
divdavem
force-pushed
the
datePickerBug
branch
from
1acf4b2
to
d5a0fba
Compare
|
Thanks for the fix! And, hmm, maybe having the overlap between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
navigation == "arrows"on the datepicker component, navigation arrows are under thediv.ngb-dp-monthelement, which prevents the click event from reaching navigation arrows on Firefox.As this is a CSS styling issue and there is not any end-to-end protractor tests configured yet, I have not included any test in this PR. The issue is reproducible on the demo site, go to the "Multiple months" example, and choose "Without select boxes" in the select. Then click on the arrows to navigate in the date picker, and nothing happens in Firefox.