Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(timepicker): add input and meridian button sizing #1258

Closed
wants to merge 1 commit into from
Closed

feat(timepicker): add input and meridian button sizing #1258

wants to merge 1 commit into from

Conversation

thejewdude
Copy link
Contributor

@thejewdude thejewdude commented Jan 25, 2017 •
edited

closes #1094

@pkozlowski-opensource
Copy link
Member

Thnx @yehudag - I've merged it since it looks about fine. One issue I could see, thought, is that chevrons look disproportionately small for size="large". Could you follow up with another PR that make those bigger when we use size="large"?

I'm thinking if it wouldn't be easier to turn those chevrons into SVG so it is easier to scale them...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: timepicker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timepicker feature request: allow for setting the underlying input control size
2 participants
@thejewdude @pkozlowski-opensource