Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timepicker: support change size of the chevrons #1300

Closed
peterhe2000 opened this issue Feb 8, 2017 · 4 comments
Closed

timepicker: support change size of the chevrons #1300

peterhe2000 opened this issue Feb 8, 2017 · 4 comments

Comments

@peterhe2000
Copy link

Hi. Is it possible to change size of the chevrons?

Version of Angular, ng-bootstrap, and Bootstrap:

Angular: 2.4.5

ng-bootstrap: 1.0.0-alpha.20

Bootstrap: 4.0.0-alpha.6

@dmytroyarmak
Copy link
Contributor

@peterhe2000 Please use StackOverflow for general help questions: https://github.com/ng-bootstrap/ng-bootstrap#getting-help

@pkozlowski-opensource
Copy link
Member

@dmytroyarmak I think that the issue here is that chevrons are not scalling properly with the size option. We should convert them to svg and scale properly. This would be a good issue if you are looking for one :-)

@dmytroyarmak
Copy link
Contributor

@pkozlowski-opensource Yeah, they are always the same will all "size" options.
We can also do it in a little bit different way - we can for different "size" attributes change class on buttons with chevron to btn-sm, btn-lg or no additional class. Changes of the button will cause increasing or decreasing of font size and it will make chevron bigger or smaller.
What do you think about this approach?

@pkozlowski-opensource
Copy link
Member

@dmytroyarmak if sticking different class names on buttons does the trick, then yes, please open a PR. Thnx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants