feat(pagination): remove duplicate accessibility labels #1429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thbt I'm not sure I understand reasoning behind the test changes. Could you please have a look at my comments and clarify? |
thbt
force-pushed
the
pagination-span
branch
2 times, most recently
from
0ee27dd
to
7dffaf6
Compare
Remove the `.sr-only` span for boundary and direction links as there already is an `aria-label`
|
There was some code left over from another PR, it's fine now. I modified the tests because there is no "Previous" or "Next" in the text, since it is only present in the aria-label. I can add a test to check that there is actually an aria-label if you want. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
.sr-onlyspan for boundary and direction links as there already is anaria-label, which is in the standard and is supported by most screen readers.This is based on a recommandation i made on this issue : twbs/boostrap#22009
Before submitting a pull request, please make sure you have at least performed the following: