New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(carousel): remove inappropriate role="listbox" from carousel #1484

Closed

thbt wants to merge 1 commit into ng-bootstrap:master from thbt:carousel-listbox

Contributor

thbt commented Apr 12, 2017

Based on this issue : twbs/bootstrap#22061.

Before submitting a pull request, please make sure you have at least performed the following:

read and followed the CONTRIBUTING.md guide.
built and tested the changes locally.
added/updated any applicable tests.
added/updated any applicable API documentation.
added/updated any applicable demos.


          fix(carousel): remove inappropriate role="listbox" from carousel

7a09ae6

pkozlowski-opensource added this to the 1.0.0-alpha.23 milestone

Member

pkozlowski-opensource commented Apr 12, 2017

LGTM

pkozlowski-opensource closed this in

39e1df5

thbt deleted the carousel-listbox branch

April 12, 2017 15:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment