-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): change trigger event for NgbInputDatepicker #1605
Conversation
@PerfectPixel thnx for the PR, it looks good. One question though - did you test it on IE10/11 and / or Edge? I recall that there are some issues with how the |
@pkozlowski-opensource ok there is a rub. This line causes the following behaviour:
Here is a gif where I am typing numbers randomly. The easiest solution is to uncomment this line. However, there are a few changes in behaviour:
Edit: The input event itself works fine using IE 11 and Edge |
@pkozlowski-opensource have a look at my last commit. This fixes the input. Also, it mitigates the first issue as I introduced a change event that updates the view with the model enabling autocomplete of the day once again. The 2nd and 3rd issues are also happening in the original version just on a different event. |
@PerfectPixel it all looks good to me! We've got a big PR for date picker in-flight (keyboard navigation) so I'm going to wait with merging till the end of the week (so other PR can land first). Thnx! |
@PerfectPixel the other PR I've mentioned just landed so we can get in this one. Would you mind rebasing so we can land your PR? |
Not at all, I'll have a look at it tonight |
@pkozlowski-opensource all done :-) |
Changes the trigger event in NgbInputDatepicker for manual date change from
change
toinput
as discussed in #1225.