Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tabset.ts #1661

Closed
wants to merge 1 commit into from
Closed

Update tabset.ts #1661

wants to merge 1 commit into from

Conversation

IsaacSee
Copy link

@IsaacSee IsaacSee commented Jul 7, 2017

Add 'bordered' as new allowed value for tabset "type" attribute (bordered list are used by dashboard official bootstrap theme)

Add 'bordered' as new allowed value for tabset "type" attribute (bordered list are used by dashboard official bootstrap theme)
@pkozlowski-opensource
Copy link
Member

@IsaacSee thnx. Could you please link to the "official bootstrap theme" where we could see the effect of applying "bordered" type?

@IsaacSee
Copy link
Author

IsaacSee commented Jul 9, 2017

@pkozlowski-opensource
Copy link
Member

We should rather allow any nav type as in #2592 instead of having hard-coded value for one particular theme. Closing in favour of #2592

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants