feat(modal): add injector option #1685
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-duch
force-pushed
the
master
branch
5 times, most recently
from
9eeee10
to
4e5d415
Compare
|
LGTM. This change makes sense, I wanted to add it at some point but wanted to wait till someone comes up with a real-life use-case. Merging, thnx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have an application whose components depend heavily on scoped providers, which makes it difficult to reuse those components within a modal. This has also come up on stack overflow (we do something similar with a reflective injector):
https://stackoverflow.com/questions/42568336/how-to-open-a-component-in-ng-bootstrap-modal-using-a-specific-injector
We made a small change: add a property 'injector: Injector' to NgbModalOptions and use that within NgbModalStack.open
this._getContentRef(moduleCFR, contentInjector, content, activeModal);
-->
this._getContentRef(moduleCFR, options.injector || contentInjector, content, activeModal);