feat(buttons): add support for checkbox buttons #1688
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
changed the title
|
@maxokorokov could you PTAL? |
maxokorokov
reviewed
Jul 19, 2017
src/buttons/checkbox.ts
Outdated
| checked; | ||
|
|
||
| /** | ||
| * A flag indicating if a given radio button is disabled. |
|
|
||
| @Directive({selector: '[ngbButtonLabel]', host: {'[class.btn]': 'true'}}) | ||
| export class NgbButtonLabel { | ||
| constructor(private _renderer: Renderer2, private _elRef: ElementRef) {} |
There was a problem hiding this comment.
True that we could have done it with 3 fields and host bindings, don't really need Renderer, right?
There was a problem hiding this comment.
Yep, will send a follow up PR to refactor it. Just didn't want to make too many changes in one PR.
| * specified via ngModel. | ||
| */ | ||
| @Directive({ | ||
| selector: '[ngbButton][type=checkbox]', |
There was a problem hiding this comment.
Ha, that's a much better solution!
src/index.ts
Outdated
| @@ -27,7 +27,7 @@ export { | |||
| NgbPanelContent | |||
| } from './accordion/accordion.module'; | |||
| export {NgbAlertModule, NgbAlertConfig, NgbAlert} from './alert/alert.module'; | |||
| export {NgbButtonsModule, NgbRadioGroup} from './buttons/radio.module'; | |||
| export {NgbButtonsModule, NgbRadioGroup} from './buttons/buttons.module'; | |||
There was a problem hiding this comment.
Seems strange, that we have only NgbRadioGroup here
There was a problem hiding this comment.
This is so people can query for it. We could add the new checkbox button here as well.
BREAKING CHANGE:
The `NgbButtonsModule` changed location (path) and content. This path
might need adjusting for people importing individual modules.
Before: `import {NgbButtonsModule} from './buttons/radio.module'`
After: `import {NgbButtonsModule} from './buttons/buttons.module'`
The `NgbButtonsModule` now contains both checkbox and radio buttons.
Closes #890
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #890