fix(dropdown): restore support for dropups #1752
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
reviewed
Aug 21, 2017
src/dropdown/dropdown.spec.ts
Outdated
| @@ -70,8 +63,8 @@ describe('ngb-dropdown', () => { | |||
| expect(compiled).not.toBeShown(); | |||
| }); | |||
|
|
|||
| it('should be up if up input is true', () => { | |||
| const html = `<div ngbDropdown [up]="true"></div>`; | |||
| it('should have dropup CSS class is placed on top', () => { | |||
There was a problem hiding this comment.
don't really understand what you mean. is → if ?
There was a problem hiding this comment.
Yep, fixed.
src/dropdown/dropdown.ts
Outdated
| @@ -37,7 +39,11 @@ export class NgbDropdownMenu { | |||
| } | |||
| }) | |||
| export class NgbDropdownToggle { | |||
| constructor(@Inject(forwardRef(() => NgbDropdown)) public dropdown, private _elementRef: ElementRef) {} | |||
| anachorEl; | |||
| @@ -83,16 +86,26 @@ export class NgbDropdown { | |||
| @Input('open') _open = false; | |||
|
|
|||
| /** | |||
| * Placement of a dropdown. Use "top-right" for dropups. | |||
There was a problem hiding this comment.
Again, I think you should either list the acceptable values in the doc or type it appropriately
There was a problem hiding this comment.
Defintivelly. We are going to add appropriate type in a PR that introduces more positioning options (including auto).
rmeans
pushed a commit
to fcsa-teamhammer/ng-bootstrap
that referenced
this pull request
Oct 18, 2017
Fixes ng-bootstrap#1747 Part of ng-bootstrap#1171 Part of ng-bootstrap#1012 BREAKING CHANGE: The `up` input is no longer supported by you can use more flexible `placement` setting now. Before: ```html <div ngbDropdown [up]="true"> ``` After: ```html <div ngbDropdown placement="top-right"> ``` Closes ng-bootstrap#1752
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1747
Part of #1171
Part of #1012
BREAKING CHANGE:
The
upinput is no longer supported by you can use more flexibleplacementsetting now.Before:
After: