Feature auto placements #1782
Closed
Feature auto placements #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mschoudry I've just merged your other PR as 4f1e518 . Could you please rebase this PR on top of the current master and squash all the commits into one? I will do another review and hopefully we will able to land this one soon! Thnx! |
mschoudry
force-pushed
the
feature_auto_placements
branch
4 times, most recently
from
2346251
to
7d195b5
Compare
mschoudry
force-pushed
the
feature_auto_placements
branch
from
7d195b5
to
df74ca6
Compare
|
LGTM. Merging, thnx! |
rmeans
pushed a commit
to fcsa-teamhammer/ng-bootstrap
that referenced
this pull request
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for Auto placement and placement array.