-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(progressbar): specify height #1908
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just one minor comment about documentation.
Also this will change in 4.0.0-beta.2
, as the height will be set on <div class="progress">
directly, so this will need to be updated soon.
src/progressbar/progressbar.ts
Outdated
@@ -50,12 +51,18 @@ export class NgbProgressbar { | |||
*/ | |||
@Input() value = 0; | |||
|
|||
/** | |||
* Height of the progress bar |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we should clarify, as it will end up in the documentation:
Something like:
Height of the progress bar. Accepts any valid CSS height values, ex. '2rem'
what's the best way to make sure to update that when we upgrade? |
2214ea6
to
2444c85
Compare
I guess the easiest would be for you to realign and update current PR once #1914 will land in master. Or just test locally with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align with latest Bootstrap markup:
https://getbootstrap.com/docs/4.0/components/progress/#height
2444c85
to
a381aad
Compare
a381aad
to
0d4785c
Compare
Thanks for contributing, @chenyuzhcy! |
#1904