Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date-picker with multiple months does not print unavailable dates #2035

Closed
TheGlockZentix opened this issue Dec 13, 2017 · 5 comments
Closed

Comments

@TheGlockZentix
Copy link

Date-picker with multiple months does not print unavailable dates.
See picture below:
https://i.imgur.com/u79v1RH.png

@pkozlowski-opensource
Copy link
Member

Yep, looks like a bug to me - I can't even force it to explicitly display: http://plnkr.co/edit/OxbizKp0Zq02zhImem9u?p=preview

cc @maxokorokov

@bastienmoulia
Copy link
Contributor

Due to [outsideDays]="(displayMonths === 1 ? outsideDays : 'hidden')" from https://github.com/ng-bootstrap/ng-bootstrap/blob/master/src/datepicker/datepicker.ts#L126.

What is the correct behavior:

  1. Hide days outside of the month like actually
  2. Show days outside of the month (in grey)
  3. Hide days between the 2 month and show days before and after (in grey)

@pkozlowski-opensource
Copy link
Member

Hmm, good questions @bastienmoulia ! I would say (1) or (3), but I will let @maxokorokov to decide.

@maxokorokov
Copy link
Member

maxokorokov commented Jan 12, 2018

It is related to [outsideDays], true. More specifically what to do with days in between two months.

I would say all (1) and (2) depend on the outsideDays value, (3) is always correct (days in between are never visible).

Please see discussion and my comment here: #1158 (comment)

@phatvuong194
Copy link

did you fix this bug?
https://i.imgur.com/u79v1RH.png

@maxokorokov maxokorokov modified the milestones: 1.1.2, 2.1.0 Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants