feat(datepicker): use the angular locale API #2066
Conversation
|
@maxokorokov I would love to land this one, but I would live to have your opinion first. Could you PTAL? |
There was a problem hiding this comment.
Thanks for the update, LGTM generally speaking.
One comment: we should use FormStyle.Standalone instead of FormStyle.Format, as the former is in Nominative and latter is Genitive. Checked for Russian and current solution returns incorrect form.
And a minor concern: these APIs are still marked as experimental, but I guess it shouldn't be a problem
src/datepicker/datepicker-i18n.ts
Outdated
| @@ -34,9 +30,23 @@ export abstract class NgbDatepickerI18n { | |||
|
|
|||
| @Injectable() | |||
| export class NgbDatepickerI18nDefault extends NgbDatepickerI18n { | |||
| getWeekdayShortName(weekday: number): string { return WEEKDAYS_SHORT[weekday - 1]; } | |||
| private weekdaysShort: Array<string>; | |||
There was a problem hiding this comment.
If you'll be fixing FormStyle.Format, could you also prefix these with _ as we usually do with private members
the datepicker now honors the Angular LOCALE_ID and uses the registered locale data to internationalize the months and days names. Unless you really want custom names, providing a custom NgbDatepickerI18n service isn't necessary anymore to internationalize the datepicker. fix ng-bootstrap#2065 BREAKING CHANGE: if your application provides a LOCALE_ID other than the default en-US, registers the locale data for this locale, and doesn't use a custom NgbDatepickerI18n, then the days and months of the datepicker won't be displayed in English anymore, but in the langguage of the provided locale.
jnizet
force-pushed
the
feat/2065-datepicker-i18n
branch
from
64cb47c
to
2311616
Compare
|
@maxokorokov sorry for the late update. I somehow missed your review, then was in holiday. I applied your suggested fixes and rebased on master. |
|
I would be nice to add a default implementation of |
the datepicker now honors the Angular LOCALE_ID and uses the registered
locale data to internationalize the months and days names. Unless you
really want custom names, providing a custom NgbDatepickerI18n service
isn't necessary anymore to internationalize the datepicker.
fix #2065
BREAKING CHANGE: if your application provides a LOCALE_ID other than
the default en-US, registers the locale data for this locale, and
doesn't use a custom NgbDatepickerI18n, then the days and months
of the datepicker won't be displayed in English anymore, but in the
langguage of the provided locale.