Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): Add vertically centered option #2074

Closed
wants to merge 1 commit into from
Closed

feat(modal): Add vertically centered option #2074

wants to merge 1 commit into from

Conversation

bastienmoulia
Copy link
Contributor

Fix #1124

Also rename the modal documentation custom class in options with the following options:

  • windowClass: 'dark-modal'
  • size: 'sm'
  • size: 'lg'
  • verticallyCentered: true

@sciotta
Copy link

sciotta commented Feb 5, 2018

I really need this!

@ThrownLemon
Copy link

I would be happy to test this in my project.
Is there an easy way to import this version/commit using npm?

@DamianKedzior
Copy link

+1 For vertically centered option which is build-in in Bootstrap: https://getbootstrap.com/docs/4.0/components/modal/#vertically-centered
It just requires adding a new class. I tried to achieve it by adding "modal-dialog-centered" class to "windowClass" option but it adds the class to element instead of first

element which has "modal-dialog" class applied.

Maybe "windowClass" should add these classes directly to

element instead of element.

@thylux
Copy link

thylux commented Feb 28, 2018

Looking forward to use this too.

@wgraham17
Copy link

Any chance this can get reviewed and pulled in?

@pkozlowski-opensource pkozlowski-opensource added this to the 1.1.0 milestone Mar 16, 2018
@pkozlowski-opensource
Copy link
Member

Adding it to the next feature-release (1.1.0) milestone.

@pkozlowski-opensource
Copy link
Member

Thnx so much for this PR @bastienmoulia - I've resolved conflicts and landed it as 00e79c4 .
I've also changed the option name to better align with the Bootstrap's class name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants