feat(dropdown): allow using any event to toggle dropdowns #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
reviewed
Jan 19, 2018
There was a problem hiding this comment.
A couple of comments:
- rename
datepicker→dropdownin the commit message. You tricked me into reviewing it, didn't you? :) - there is no documentation API generated for the
ngbDropDownAnchor - I didn't get how it would work with say
focusandblurevents... demo/doc missing?
maxokorokov
reviewed
Jan 19, 2018
src/dropdown/dropdown.ts
Outdated
| /** | ||
| * Marks an element to which dropdown menu will be anchored. This is a simple version | ||
| * of the NgbDropdownToggle directive. It plays the same role as NgbDropdownToggle but | ||
| * don't listen to click events to toggle dropdown menu thus enabling support for |
maxokorokov
changed the title
|
@maxokorokov thnx for the review, all the valid points! I believe I've fixed all the issues you've spotted - could you please have another look? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1115
Fixes #1926