fix(modal): don't use inline styles #2223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI failure is a flake |
maxokorokov
reviewed
Mar 16, 2018
src/modal/modal-backdrop.ts
Outdated
| @@ -1,5 +1,5 @@ | |||
| import {Component} from '@angular/core'; | |||
|
|
|||
| @Component({selector: 'ngb-modal-backdrop', template: '', host: {'class': 'modal-backdrop fade show'}}) | |||
| @Component({selector: 'ngb-modal-backdrop', template: '', host: {'class': 'modal-backdrop show'}}) | |||
There was a problem hiding this comment.
Not sure about removing the fadeclass and leaving show. Take a look at BS styles:
Should we remove both?
There was a problem hiding this comment.
Yeh, probably... I was just afraid that people might be using show class for some reason (DOM manipulation). But in this case I should not be removing fade...
I will revert all this for now and only do inline style => d-block in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2085