Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(accordion): properly determine titles when using nested accordions #2247

Closed
wants to merge 1 commit into from
Closed

fix(accordion): properly determine titles when using nested accordions #2247

wants to merge 1 commit into from
+44 −4

Conversation

pkozlowski-opensource
Copy link
Member

Fixes #2240

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Mar 23, 2018
Closed
maxokorokov
maxokorokov approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/accordion/accordion.spec.ts
`;
const fixture = createTestComponent(testHtml);

fixture.detectChanges();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: kind of redundant, as createTestComponent already does it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the bug can only be reproduced if you run another round of change detection, so it is deliberate here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, a comment then?

@maxokorokov maxokorokov added this to the 1.0.3 milestone Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees
No one assigned
Labels
component: accordion needs: merging type: bug
Projects
None yet
Milestone
1.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkozlowski-opensource @maxokorokov