Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): add native js date adapter #2305

Merged
merged 1 commit into from
Jun 4, 2018
Merged

feat(datepicker): add native js date adapter #2305

merged 1 commit into from
Jun 4, 2018

Conversation

msosa
Copy link
Contributor

@msosa msosa commented Apr 12, 2018

Implements part 1 of #1977 and adds NgbDateNativeAdapter to the library

Let me know how this looks @maxokorokov and if there any changes you think are needed

@maxokorokov maxokorokov self-assigned this Apr 12, 2018
@maxokorokov maxokorokov added this to the 2.1.0 milestone Apr 13, 2018
maxokorokov
maxokorokov approved these changes Apr 17, 2018
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks, @msosa !

@msosa
Copy link
Contributor Author

msosa commented Apr 17, 2018

no problem! I'll take a look at ISO later

@pkozlowski-opensource pkozlowski-opensource modified the milestones: 2.1.0, 2.2.0 Jun 1, 2018
@maxokorokov maxokorokov modified the milestones: 2.2.0, 2.1.0 Jun 4, 2018
@maxokorokov maxokorokov merged commit cd14b96 into ng-bootstrap:master Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees

@maxokorokov maxokorokov

Labels
component: datepicker type: feature
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@msosa @maxokorokov @pkozlowski-opensource